Skip to content

Commit

Permalink
Merge branch 'main' of https://github.com/risingwavelabs/risingwave i…
Browse files Browse the repository at this point in the history
…nto li0k/storage_fix_compactor_memory_limit
  • Loading branch information
Li0k committed Feb 4, 2024
2 parents 62073e6 + 5f741c6 commit 8a538c1
Show file tree
Hide file tree
Showing 51 changed files with 1,113 additions and 616 deletions.
8 changes: 6 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

56 changes: 45 additions & 11 deletions ci/workflows/main-cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ steps:
timeout_in_minutes: 12
retry: *auto-retry

- label: "build (deterministic simulation)"
- label: "build simulation test"
command: "ci/scripts/build-simulation.sh"
if: |
!(build.pull_request.labels includes "ci/main-cron/skip-ci") && build.env("CI_STEPS") == null
Expand Down Expand Up @@ -214,7 +214,7 @@ steps:
timeout_in_minutes: 22
retry: *auto-retry

- label: "unit test (deterministic simulation)"
- label: "unit test (madsim)"
key: "unit-test-deterministic"
command: "MADSIM_TEST_NUM=100 timeout 15m ci/scripts/deterministic-unit-test.sh"
if: |
Expand All @@ -229,7 +229,7 @@ steps:
timeout_in_minutes: 15
retry: *auto-retry

- label: "integration test (deterministic simulation) - scale"
- label: "integration test (madsim) - scale"
key: "integration-test-deterministic-scale"
command: "TEST_NUM=60 ci/scripts/deterministic-it-test.sh scale::"
if: |
Expand All @@ -246,7 +246,7 @@ steps:
timeout_in_minutes: 70
retry: *auto-retry

- label: "integration test (deterministic simulation) - recovery"
- label: "integration test (madsim) - recovery"
key: "integration-test-deterministic-recovery"
command: "TEST_NUM=60 ci/scripts/deterministic-it-test.sh recovery::"
if: |
Expand All @@ -263,9 +263,9 @@ steps:
timeout_in_minutes: 70
retry: *auto-retry

- label: "integration test (deterministic simulation) - others"
key: "integration-test-deterministic-others"
command: "TEST_NUM=30 ci/scripts/deterministic-it-test.sh backfill_tests:: storage:: sink::"
- label: "integration test (madsim) - backfill"
key: "integration-test-deterministic-backfill"
command: "TEST_NUM=30 ci/scripts/deterministic-it-test.sh backfill_tests::"
if: |
!(build.pull_request.labels includes "ci/main-cron/skip-ci") && build.env("CI_STEPS") == null
|| build.pull_request.labels includes "ci/run-integration-test-deterministic-simulation"
Expand All @@ -280,7 +280,41 @@ steps:
timeout_in_minutes: 70
retry: *auto-retry

- label: "end-to-end test (deterministic simulation)"
- label: "integration test (madsim) - storage"
key: "integration-test-deterministic-storage"
command: "TEST_NUM=30 ci/scripts/deterministic-it-test.sh storage::"
if: |
!(build.pull_request.labels includes "ci/main-cron/skip-ci") && build.env("CI_STEPS") == null
|| build.pull_request.labels includes "ci/run-integration-test-deterministic-simulation"
|| build.env("CI_STEPS") =~ /(^|,)integration-tests?-deterministic-simulation(,|$$)/
depends_on: "build-simulation"
plugins:
- docker-compose#v4.9.0:
run: rw-build-env
config: ci/docker-compose.yml
mount-buildkite-agent: true
- ./ci/plugins/upload-failure-logs
timeout_in_minutes: 70
retry: *auto-retry

- label: "integration test (madsim) - sink"
key: "integration-test-deterministic-sink"
command: "TEST_NUM=30 ci/scripts/deterministic-it-test.sh sink::"
if: |
!(build.pull_request.labels includes "ci/main-cron/skip-ci") && build.env("CI_STEPS") == null
|| build.pull_request.labels includes "ci/run-integration-test-deterministic-simulation"
|| build.env("CI_STEPS") =~ /(^|,)integration-tests?-deterministic-simulation(,|$$)/
depends_on: "build-simulation"
plugins:
- docker-compose#v4.9.0:
run: rw-build-env
config: ci/docker-compose.yml
mount-buildkite-agent: true
- ./ci/plugins/upload-failure-logs
timeout_in_minutes: 70
retry: *auto-retry

- label: "end-to-end test (madsim)"
key: "e2e-test-deterministic"
command: "TEST_NUM=64 timeout 55m ci/scripts/deterministic-e2e-test.sh"
if: |
Expand All @@ -302,7 +336,7 @@ steps:
timeout_in_minutes: 60
retry: *auto-retry

- label: "recovery test (deterministic simulation)"
- label: "recovery test (madsim)"
key: "recovery-test-deterministic"
command: "TEST_NUM=12 KILL_RATE=1.0 BACKGROUND_DDL_RATE=0.0 timeout 55m ci/scripts/deterministic-recovery-test.sh"
if: |
Expand All @@ -321,7 +355,7 @@ steps:
retry: *auto-retry

# Ddl statements will randomly run with background_ddl.
- label: "background_ddl, arrangement_backfill recovery test (deterministic simulation)"
- label: "background_ddl, arrangement_backfill recovery test (madsim)"
key: "background-ddl-arrangement-backfill-recovery-test-deterministic"
command: "TEST_NUM=12 KILL_RATE=1.0 BACKGROUND_DDL_RATE=0.8 USE_ARRANGEMENT_BACKFILL=--use-arrangement-backfill timeout 55m ci/scripts/deterministic-recovery-test.sh"
if: |
Expand All @@ -340,7 +374,7 @@ steps:
retry: *auto-retry

# Ddl statements will randomly run with background_ddl.
- label: "background_ddl recovery test (deterministic simulation)"
- label: "background_ddl recovery test (madsim)"
key: "background-ddl-recovery-test-deterministic"
command: "TEST_NUM=12 KILL_RATE=1.0 BACKGROUND_DDL_RATE=0.8 timeout 55m ci/scripts/deterministic-recovery-test.sh"
if: |
Expand Down
2 changes: 1 addition & 1 deletion dashboard/next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
* @type {import('next').NextConfig}
*/
const nextConfig = {
output: 'export',
output: "export",
trailingSlash: true,
}

Expand Down
2 changes: 1 addition & 1 deletion docker/dashboards/risingwave-dev-dashboard.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docker/dashboards/risingwave-user-dashboard.json

Large diffs are not rendered by default.

20 changes: 20 additions & 0 deletions grafana/risingwave-dev-dashboard.dashboard.py
Original file line number Diff line number Diff line change
Expand Up @@ -3678,6 +3678,26 @@ def section_memory_manager(outer_panels):
),
],
),
panels.timeseries_memory(
"The resident memory of jemalloc",
"",
[
panels.target(
f"{metric('jemalloc_resident_bytes')}",
"",
),
],
),
panels.timeseries_memory(
"The metadata memory of jemalloc",
"",
[
panels.target(
f"{metric('jemalloc_metadata_bytes')}",
"",
),
],
),
panels.timeseries_memory(
"The allocated memory of jvm",
"",
Expand Down
2 changes: 1 addition & 1 deletion grafana/risingwave-dev-dashboard.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion grafana/risingwave-user-dashboard.json

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions src/batch/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ normal = ["workspace-hack"]

[dependencies]
anyhow = "1"
arrow-array = { workspace = true }
arrow-schema = { workspace = true }
assert_matches = "1"
async-recursion = "1"
async-trait = "0.1"
Expand All @@ -24,6 +26,7 @@ futures-async-stream = { workspace = true }
futures-util = "0.3"
hashbrown = { workspace = true }
hytra = "0.1.2"
icelake = { workspace = true }
itertools = "0.12"
memcomparable = "0.2"
parking_lot = { version = "0.12", features = ["arc_lock"] }
Expand Down
7 changes: 7 additions & 0 deletions src/batch/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,13 @@ pub enum BatchError {
DmlError,
),

#[error(transparent)]
Iceberg(
#[from]
#[backtrace]
icelake::Error,
),

// Make the ref-counted type to be a variant for easier code structuring.
// TODO(error-handling): replace with `thiserror_ext::Arc`
#[error(transparent)]
Expand Down
Loading

0 comments on commit 8a538c1

Please sign in to comment.