fix(source/nats): add missing default attribute for vectors (#18261)

risingwavelabs · Aug 28, 2024 · 7998622 · 7998622
1 parent 205acb4
commit 7998622
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/connector/src/source/nats/mod.rs b/src/connector/src/source/nats/mod.rs
@@ -126,8 +126,11 @@ pub struct NatsPropertiesConsumer {
     #[serde(rename = "consumer.filter_subject")]
     pub filter_subject: Option<String>,
 
-    #[serde(rename = "consumer.filter_subjects")]
-    #[serde(deserialize_with = "deserialize_optional_string_seq_from_string")]
+    #[serde(
+        rename = "consumer.filter_subjects",
+        default,
+        deserialize_with = "deserialize_optional_string_seq_from_string"
+    )]
     pub filter_subjects: Option<Vec<String>>,
 
     #[serde(rename = "consumer.replay_policy")]
@@ -178,8 +181,11 @@ pub struct NatsPropertiesConsumer {
     #[serde_as(as = "Option<DisplayFromStr>")]
     pub memory_storage: Option<bool>,
 
-    #[serde(rename = "consumer.backoff.sec")]
-    #[serde(deserialize_with = "deserialize_optional_u64_seq_from_string")]
+    #[serde(
+        rename = "consumer.backoff.sec",
+        default,
+        deserialize_with = "deserialize_optional_u64_seq_from_string"
+    )]
     pub backoff: Option<Vec<u64>>,
 }
 

diff --git a/src/connector/with_options_source.yaml b/src/connector/with_options_source.yaml
@@ -537,6 +537,7 @@ NatsProperties:
   - name: consumer.filter_subjects
     field_type: Vec<String>
     required: false
+    default: Default::default
   - name: consumer.replay_policy
     field_type: String
     required: false
@@ -578,6 +579,7 @@ NatsProperties:
   - name: consumer.backoff.sec
     field_type: Vec<u64>
     required: false
+    default: Default::default
   - name: scan.startup.mode
     field_type: String
     required: false