Skip to content

Commit

Permalink
support pop from jsonb array builder
Browse files Browse the repository at this point in the history
Signed-off-by: Runji Wang <[email protected]>
  • Loading branch information
wangrunji0408 committed Oct 20, 2023
1 parent ff63a63 commit 730b4a5
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/common/src/array/jsonb_array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@ impl ArrayBuilder for JsonbArrayBuilder {
}

fn pop(&mut self) -> Option<()> {
self.bitmap.pop();
todo!("pop from jsonb builder");
self.bitmap.pop()?;
self.builder.pop();
Some(())
}

fn len(&self) -> usize {
Expand Down

0 comments on commit 730b4a5

Please sign in to comment.