Skip to content

Commit

Permalink
fix(test): skip creating secret file dir in simulation test (#17772)
Browse files Browse the repository at this point in the history
  • Loading branch information
yuhao-su authored Jul 23, 2024
1 parent 2b15b8e commit 69caf47
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/common/secret/src/secret_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ impl LocalSecretManager {
.join(cluster_id)
.join(worker_id.to_string());
std::fs::remove_dir_all(&secret_file_dir).ok();

// This will cause file creation conflict in simulation tests.
// Should skip testing secret files in simulation tests.
#[cfg(not(madsim))]
std::fs::create_dir_all(&secret_file_dir).unwrap();

Self {
Expand Down Expand Up @@ -87,7 +91,10 @@ impl LocalSecretManager {
"Failed to remove secret directory")
})
.ok();

#[cfg(not(madsim))]
std::fs::create_dir_all(&self.secret_file_dir).unwrap();

for secret in secrets {
secret_guard.insert(secret.id, secret.value);
}
Expand Down

0 comments on commit 69caf47

Please sign in to comment.