Skip to content

Commit

Permalink
chore: don't warn on object not found error (#13935)
Browse files Browse the repository at this point in the history
  • Loading branch information
zwang28 authored Dec 13, 2023
1 parent 3da7770 commit 5c588ef
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/object_store/src/object/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,11 @@ impl<OS: ObjectStore> MonitoredObjectStore<OS> {
.unwrap_or_else(|_| Err(ObjectError::internal("read timeout"))),
};

try_update_failure_metric(&self.object_store_metrics, &res, operation_type);
if let Err(e) = &res && e.is_object_not_found_error() && path.ends_with("manifest.json") {
// Metadata backup's manifest.json not found is expected.
} else {
try_update_failure_metric(&self.object_store_metrics, &res, operation_type);
}

let data = res?;
self.object_store_metrics
Expand Down

0 comments on commit 5c588ef

Please sign in to comment.