rename

src/frontend/src/catalog/root_catalog.rs

@@ -676,7 +676,7 @@ impl Catalog {
     }
 
     /// This function is similar to `get_table_by_id` expect that a table must be in a given database.
-    pub fn get_table_by_id_with_db(
+    pub fn get_created_table_by_id_with_db(
         &self,
         db_name: &str,
         table_id: u32,

src/frontend/src/catalog/schema_catalog.rs

@@ -560,7 +560,7 @@ impl SchemaCatalog {
     }
 
     /// Iterate all materialized views, excluding the indices.
-    pub fn iter_mv(&self) -> impl Iterator<Item = &Arc<TableCatalog>> {
+    pub fn iter_created_mvs(&self) -> impl Iterator<Item = &Arc<TableCatalog>> {
         self.table_by_name
             .iter()
             .filter(|(_, v)| v.is_mview() && valid_table_name(&v.name) && v.is_created())

src/frontend/src/catalog/system_catalog/rw_catalog/rw_materialized_views.rs

@@ -44,7 +44,7 @@ fn read_rw_materialized_views(reader: &SysCatalogReaderImpl) -> Result<Vec<RwMat
 
     Ok(schemas
         .flat_map(|schema| {
-            schema.iter_mv().map(|table| RwMaterializedView {
+            schema.iter_created_mvs().map(|table| RwMaterializedView {
                 id: table.id.table_id as i32,
                 name: table.name().into(),
                 schema_id: schema.id() as i32,

src/frontend/src/catalog/system_catalog/rw_catalog/rw_relation_info.rs

@@ -49,7 +49,7 @@ async fn read_relation_info(reader: &SysCatalogReaderImpl) -> Result<Vec<RwRelat
             let schema_catalog =
                 catalog_reader.get_schema_by_name(&reader.auth_context.database, schema)?;
 
-            schema_catalog.iter_mv().for_each(|t| {
+            schema_catalog.iter_created_mvs().for_each(|t| {
                 table_ids.push(t.id.table_id);
             });
 
@@ -78,7 +78,7 @@ async fn read_relation_info(reader: &SysCatalogReaderImpl) -> Result<Vec<RwRelat
     for schema in &schemas {
         let schema_catalog =
             catalog_reader.get_schema_by_name(&reader.auth_context.database, schema)?;
-        schema_catalog.iter_mv().for_each(|t| {
+        schema_catalog.iter_created_mvs().for_each(|t| {
             if let Some(fragments) = table_fragments.get(&t.id.table_id) {
                 rows.push(RwRelationInfo {
                     schemaname: schema.clone(),

src/frontend/src/expr/function_impl/pg_get_viewdef.rs

@@ -39,7 +39,7 @@ fn pg_get_viewdef_impl(
     if let Ok(view) = catalog_reader.get_view_by_id(db_name, oid as u32) {
         write!(writer, "{}", view.sql).unwrap();
         Ok(())
-    } else if let Ok(mv) = catalog_reader.get_table_by_id_with_db(db_name, oid as u32) {
+    } else if let Ok(mv) = catalog_reader.get_created_table_by_id_with_db(db_name, oid as u32) {
         let stmts = Parser::parse_sql(&mv.definition).map_err(|e| anyhow!(e))?;
         let [stmt]: [_; 1] = stmts.try_into().unwrap();
 

src/frontend/src/handler/show.rs

@@ -311,7 +311,7 @@ pub async fn handle_show_object(
         ShowObject::MaterializedView { schema } => catalog_reader
             .read_guard()
             .get_schema_by_name(session.database(), &schema_or_default(&schema))?
-            .iter_mv()
+            .iter_created_mvs()
             .map(|t| t.name.clone())
             .collect(),
         ShowObject::Source { schema } => catalog_reader