generalize WindowBuffer

Signed-off-by: Richard Chien <[email protected]>
risingwavelabs · Jan 18, 2024 · 5840681 · 5840681
1 parent 3181b68
commit 5840681
Show file tree

Hide file tree

Showing 4 changed files with 245 additions and 152 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/src/expr/core/Cargo.toml b/src/expr/core/Cargo.toml
@@ -31,6 +31,7 @@ chrono = { version = "0.4", default-features = false, features = [
 ctor = "0.2"
 downcast-rs = "1.2"
 easy-ext = "1"
+educe = "0.5"
 either = "1"
 enum-as-inner = "0.6"
 futures-async-stream = { workspace = true }

diff --git a/src/expr/core/src/window_function/call.rs b/src/expr/core/src/window_function/call.rs
@@ -143,14 +143,18 @@ impl FrameBounds {
     }
 }
 
+pub trait FrameBoundsImpl {
+    fn validate(&self) -> Result<()>;
+}
+
 #[derive(Display, Debug, Clone, Eq, PartialEq, Hash)]
 #[display("ROWS BETWEEN {start} AND {end}")]
 pub struct RowsFrameBounds {
     pub start: FrameBound<usize>,
     pub end: FrameBound<usize>,
 }
 
-impl RowsFrameBounds {
+impl FrameBoundsImpl for RowsFrameBounds {
     fn validate(&self) -> Result<()> {
         FrameBound::validate_bounds(&self.start, &self.end)
     }