simplify feature gate

Signed-off-by: Bugen Zhao <[email protected]>

ci/scripts/release.sh

@@ -39,7 +39,6 @@ source "$HOME/.cargo/env"
 rustup show
 source ci/scripts/common.sh
 unset RUSTC_WRAPPER # disable sccache
-export TODO_DISABLE_EMBEDDED_DASHBOARD=1 # TODO(bugen): remove this after the embedded dashboard is ready
 
 echo "--- Install protoc3"
 PROTOC_ARCH=${ARCH}

docker/Dockerfile

@@ -76,8 +76,6 @@ ENV GIT_SHA=$GIT_SHA
 COPY ./ /risingwave
 WORKDIR /risingwave
 
-# TODO(bugen): remove this after the embedded dashboard is ready
-ENV TODO_DISABLE_EMBEDDED_DASHBOARD=1
 RUN cargo fetch && \
   cargo build -p risingwave_cmd_all --release --features "rw-static-link" --features embedded-python-udf && \
   mkdir -p /risingwave/bin && \

src/meta/dashboard/build.rs

@@ -61,13 +61,7 @@ fn build() -> anyhow::Result<()> {
 }
 
 fn main() -> anyhow::Result<()> {
-    rerun_if_changed!("build.rs");
-
-    let should_build = env_var_is_true("ENABLE_BUILD_DASHBOARD") // asked to build by RiseDev
-        || (std::env::var("PROFILE").unwrap() == "release" && !env_var_is_true("RISINGWAVE_CI")); // release build and not in CI
-
-    // TODO(bugen): remove this after the embedded dashboard is ready
-    let should_build = should_build && !env_var_is_true("TODO_DISABLE_EMBEDDED_DASHBOARD");
+    let should_build = env_var_is_true("ENABLE_BUILD_DASHBOARD");
 
     if should_build {
         build()?;

src/meta/dashboard/src/lib.rs

@@ -24,13 +24,16 @@ mod proxy;
 /// Based on the configuration, it will either serve the assets embedded in the binary,
 /// or proxy all requests to the latest static files built and hosted on GitHub.
 ///
-/// - For development and CI builds, the requests to the dashboard will be proxied. This
-///   is to reduce the build time and eliminate the dependency on `node`, so that the
-///   developer experience can be better.
+/// - If env var `ENABLE_BUILD_DASHBOARD` is not set during the build, the requests to
+///   the dashboard will be proxied. This is to reduce the build time and eliminate the
+///   dependency on `node`, so that the developer experience can be better. This is the
+///   default behavior for CI and development builds.
 ///
-/// - For release builds, the assets will built in the build script and embedded in the
-///   binary. This is to make the deployment easier and the dashboard more reliable
-///   without relying on external or remote resources.
+/// - If env var `ENABLE_BUILD_DASHBOARD` is set during the build, the assets will be
+///   built in the build script and embedded in the binary. This is to make the
+///   deployment easier and the dashboard more reliable without relying on external or
+///   remote resources. This is the default behavior for versioned releases, and can be
+///   manually enabled for development builds with RiseDev.
 ///
 /// If you're going to develop with the dashboard, see `dashboard/README.md` for more
 /// details.

src/meta/src/dashboard/mod.rs

@@ -412,7 +412,7 @@ impl DashboardService {
 
         let trace_ui_router = otlp_embedded::ui_app(srv.trace_state.clone(), "/trace/");
         let dashboard_router = if let Some(ui_path) = ui_path {
-            // TODO(bugen): remove `ui_path`
+            // TODO(bugen): remove `ui_path` and all in the embedded `risingwave_meta_dashboard`.
             get_service(ServeDir::new(ui_path))
                 .handle_error(|e| async move { match e {} })
                 .boxed_clone()