chore(metrics): address metrics issue

risingwavelabs · Sep 18, 2024 · 5274d34 · 5274d34
1 parent 5c257c2
commit 5274d34
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/docker/dashboards/risingwave-dev-dashboard.json b/docker/dashboards/risingwave-dev-dashboard.json
diff --git a/grafana/risingwave-dev-dashboard.dashboard.py b/grafana/risingwave-dev-dashboard.dashboard.py
@@ -3264,7 +3264,7 @@ def section_hummock_manager(outer_panels):
 
                         panels.target(
                             f"sum({table_metric('storage_merge_compaction_group_count')}) by (group)",
-                            "merge_compaction_group_count left-{{group_left}} right-{{group_right}}",
+                            "merge_compaction_group_count cg-{{group}}",
                         ),
                     ],
                 ),

diff --git a/grafana/risingwave-dev-dashboard.json b/grafana/risingwave-dev-dashboard.json
diff --git a/src/meta/src/hummock/manager/compaction/compaction_group_schedule.rs b/src/meta/src/hummock/manager/compaction/compaction_group_schedule.rs
@@ -260,7 +260,7 @@ impl HummockManager {
 
         self.metrics
             .merge_compaction_group_count
-            .with_label_values(&[&group_1.to_string(), &group_2.to_string()])
+            .with_label_values(&[&left_group_id.to_string()])
             .inc();
 
         Ok(())

diff --git a/src/meta/src/rpc/metrics.rs b/src/meta/src/rpc/metrics.rs
@@ -735,7 +735,7 @@ impl MetaMetrics {
         let merge_compaction_group_count = register_int_counter_vec_with_registry!(
             "storage_merge_compaction_group_count",
             "Count of trigger merge compaction group",
-            &["group_left", "group_right"],
+            &["group"],
             registry
         )
         .unwrap();