Skip to content

Commit

Permalink
remove resolved comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kwannoel committed Jul 22, 2024
1 parent 9ef2245 commit 4fa8ad6
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/frontend/src/optimizer/plan_node/logical_agg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@ impl LogicalAgg {
}
}

// TODO(kwannoel): Handle multiple approx_percentile.
fn separate_normal_and_special_agg(&self) -> SeparatedAggInfo {
let estimated_len = self.agg_calls().len() - 1;
let mut approx_percentile_agg_calls = Vec::with_capacity(estimated_len);
Expand Down Expand Up @@ -749,7 +748,6 @@ impl LogicalAggBuilder {
/// 2. Add the agg call to current `Agg`, and return an `InputRef` to it.
///
/// Note that the rewriter does not traverse into inputs of agg calls.
/// FIXME(kwannoel): Rewrite the desc approx percentile for descending order.
fn try_rewrite_agg_call(&mut self, mut agg_call: AggCall) -> Result<ExprImpl> {
if matches!(agg_call.agg_kind, agg_kinds::must_have_order_by!())
&& agg_call.order_by.sort_exprs.is_empty()
Expand Down

0 comments on commit 4fa8ad6

Please sign in to comment.