chore(metrics): fix executor cache miss ratio metrics (#12756)

Signed-off-by: MrCroxx <[email protected]>
risingwavelabs · Oct 11, 2023 · 4ce28cd · 4ce28cd
1 parent 9aac181
commit 4ce28cd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/stream/src/executor/managed_state/join/mod.rs b/src/stream/src/executor/managed_state/join/mod.rs
@@ -196,25 +196,25 @@ impl JoinHashMapMetrics {
 
     pub fn flush(&mut self) {
         self.metrics
-            .join_lookup_miss_count
+            .join_lookup_total_count
             .with_label_values(&[
                 (self.side),
                 &self.join_table_id,
                 &self.degree_table_id,
                 &self.actor_id,
                 &self.fragment_id,
             ])
-            .inc_by(self.lookup_miss_count as u64);
+            .inc_by(self.total_lookup_count as u64);
         self.metrics
-            .join_total_lookup_count
+            .join_lookup_miss_count
             .with_label_values(&[
                 (self.side),
                 &self.join_table_id,
                 &self.degree_table_id,
                 &self.actor_id,
                 &self.fragment_id,
             ])
-            .inc_by(self.total_lookup_count as u64);
+            .inc_by(self.lookup_miss_count as u64);
         self.metrics
             .join_insert_cache_miss_count
             .with_label_values(&[

diff --git a/src/stream/src/executor/monitor/streaming_stats.rs b/src/stream/src/executor/monitor/streaming_stats.rs
@@ -76,7 +76,7 @@ pub struct StreamingMetrics {
 
     // Streaming Join
     pub join_lookup_miss_count: GenericCounterVec<AtomicU64>,
-    pub join_total_lookup_count: GenericCounterVec<AtomicU64>,
+    pub join_lookup_total_count: GenericCounterVec<AtomicU64>,
     pub join_insert_cache_miss_count: GenericCounterVec<AtomicU64>,
     pub join_actor_input_waiting_duration_ns: GenericCounterVec<AtomicU64>,
     pub join_match_duration_ns: GenericCounterVec<AtomicU64>,
@@ -389,7 +389,7 @@ impl StreamingMetrics {
         )
         .unwrap();
 
-        let join_total_lookup_count = register_int_counter_vec_with_registry!(
+        let join_lookup_total_count = register_int_counter_vec_with_registry!(
             "stream_join_lookup_total_count",
             "Join executor lookup total operation",
             &[
@@ -946,7 +946,7 @@ impl StreamingMetrics {
             mview_input_row_count,
             exchange_frag_recv_size,
             join_lookup_miss_count,
-            join_total_lookup_count,
+            join_lookup_total_count,
             join_insert_cache_miss_count,
             join_actor_input_waiting_duration_ns,
             join_match_duration_ns,