Skip to content

Commit

Permalink
further disable for now
Browse files Browse the repository at this point in the history
Signed-off-by: Bugen Zhao <[email protected]>
  • Loading branch information
BugenZhao committed Mar 13, 2024
1 parent 216bf1e commit 42fae1e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
3 changes: 1 addition & 2 deletions ci/scripts/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ source "$HOME/.cargo/env"
rustup show
source ci/scripts/common.sh
unset RUSTC_WRAPPER # disable sccache
# TODO: uncomment this line to use embedded dashboard in release build
# unset RISINGWAVE_CI # disable ci mode, this is critical for building and embedding the dashboard assets
export TODO_DISABLE_EMBEDDED_DASHBOARD=1 # TODO(bugen): remove this after the embedded dashboard is ready

echo "--- Install protoc3"
PROTOC_ARCH=${ARCH}
Expand Down
2 changes: 2 additions & 0 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ ENV GIT_SHA=$GIT_SHA
COPY ./ /risingwave
WORKDIR /risingwave

# TODO(bugen): remove this after the embedded dashboard is ready
ENV TODO_DISABLE_EMBEDDED_DASHBOARD=1
RUN cargo fetch && \
cargo build -p risingwave_cmd_all --release --features "rw-static-link" --features embedded-python-udf && \
mkdir -p /risingwave/bin && \
Expand Down
5 changes: 5 additions & 0 deletions src/meta/dashboard/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,14 @@ fn build() -> anyhow::Result<()> {
}

fn main() -> anyhow::Result<()> {
rerun_if_changed!("build.rs");

let should_build = env_var_is_true("ENABLE_BUILD_DASHBOARD") // asked to build by RiseDev
|| (std::env::var("PROFILE").unwrap() == "release" && !env_var_is_true("RISINGWAVE_CI")); // release build and not in CI

// TODO(bugen): remove this after the embedded dashboard is ready
let should_build = should_build && !env_var_is_true("TODO_DISABLE_EMBEDDED_DASHBOARD");

if should_build {
build()?;
// Once build succeeded, set a cfg flag to indicate that the embedded assets
Expand Down

0 comments on commit 42fae1e

Please sign in to comment.