Skip to content

Commit

Permalink
fix rest
Browse files Browse the repository at this point in the history
Signed-off-by: Bugen Zhao <[email protected]>
  • Loading branch information
BugenZhao committed Feb 23, 2024
1 parent 4257336 commit 3c8896a
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/frontend/planner_test/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -944,7 +944,7 @@ pub async fn run_test_file(file_path: &Path, file_content: &str) -> Result<()> {
"Test #{i} (id: {}) failed, SQL:\n{}\nError: {}",
c.id().clone().unwrap_or_else(|| "<none>".to_string()),
c.sql(),
e
e.as_report()
);
failed_num += 1;
}
Expand Down
3 changes: 2 additions & 1 deletion src/meta/src/dashboard/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ use axum::Router;
use hyper::Request;
use parking_lot::Mutex;
use risingwave_rpc_client::ComputeClientPool;
use thiserror_ext::AsReport;
use tower::{ServiceBuilder, ServiceExt};
use tower_http::add_extension::AddExtensionLayer;
use tower_http::cors::{self, CorsLayer};
Expand Down Expand Up @@ -455,7 +456,7 @@ impl DashboardService {
proxy::proxy(req, cache).await.or_else(|err| {
Ok((
StatusCode::INTERNAL_SERVER_ERROR,
format!("Unhandled internal error: {}", err),
err.context("Unhandled internal error").to_report_string(),
)
.into_response())
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ impl CoordinatorWorker {
.wait_for_writers(first_writer_request.vnode_bitmap)
.await
{
error!("failed to wait for all writers: {:?}", e);
error!(error = %e.as_report(), "failed to wait for all writers");
worker
.send_to_all_sink_writers(|| {
Err(Status::cancelled("failed to wait for all writers"))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use std::time::Duration;

use anyhow::{anyhow, Result};
use risingwave_common::error::v2::AsReport;
use risingwave_simulation::cluster::{Cluster, Configuration, Session};
use tokio::time::sleep;

Expand Down Expand Up @@ -348,7 +349,7 @@ async fn test_high_barrier_latency_cancel(config: Configuration) -> Result<()> {
.run("CREATE MATERIALIZED VIEW mv1 as values(1)")
.await
{
tracing::info!("Recreate mv failed with {e:?}");
tracing::info!(error = %e.as_report(), "Recreate mv failed");
continue;
} else {
tracing::info!("recreated mv");
Expand Down

0 comments on commit 3c8896a

Please sign in to comment.