update comments

risingwavelabs · Sep 29, 2023 · 3469b2c · 3469b2c
1 parent d13480d
commit 3469b2c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/compute/src/memory_management/policy.rs b/src/compute/src/memory_management/policy.rs
@@ -122,7 +122,7 @@ impl JemallocMemoryControl {
                 .unwrap()
                 .to_string();
 
-            // FIXME: file_path_str is leaked
+            // `file_path_str` is leaked because `jemalloc_dump_mib.write` requires static lifetime
             let file_path_str = Box::leak(file_path.into_boxed_str());
             let file_path_bytes = file_path_str.as_bytes();
             if let Err(e) = self

diff --git a/src/compute/src/rpc/service/monitor_service.rs b/src/compute/src/rpc/service/monitor_service.rs
@@ -154,7 +154,7 @@ impl MonitorService for MonitorServiceImpl {
             .to_str()
             .ok_or_else(|| Status::internal("The file dir is not a UTF-8 String"))?;
 
-        // FIXME: file_path_str is leaked
+        // `file_path_str` is leaked because `prof::dump::write` requires static lifetime
         let file_path_str = Box::leak(file_path.to_string().into_boxed_str());
         let file_path_bytes = file_path_str.as_bytes();
         let response = if let Err(e) = tikv_jemalloc_ctl::prof::dump::write(