move node_labels and flag

risingwavelabs · Jul 22, 2024 · 342ab25 · 342ab25
1 parent 6c61679
commit 342ab25
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 19 deletions.
diff --git a/proto/catalog.proto b/proto/catalog.proto
@@ -410,25 +410,6 @@ message Table {
   // tables and tests. Not to be confused with the global catalog version for
   // notification service.
   TableVersion version = 100;
-
-  // If a materialize view, sink, or table has a node_label, its actors can only be scheduled 
-  // on compute nodes with that label.
-  // If it does not have a node_label (empty map or null value) it can be scheduled on any 
-  // compute node without a label. The node has to have both a matching key and value.
-  // E.g. {"some":"value"} can be scheduled on a node with the labels
-  // { 
-  //   "other":"thing",
-  //   "some":"value"
-  // }
-  // but {"some":"thing"} can not be scheduled on that node.
-  // A materialized view or sink or table with an empty node_labels map can only be scheduled on nodes with 
-  // empty node_labels map. 
-  // A node with an empty node_labels map can only host streaming jobs with an empty node_labels map. 
-  map<string, string> node_labels = 101;
-
-  // If this is a materialized view: True if backfill is done, else false.
-  // If this is a regular table: Always true.
-  bool backfill_done = 102;
 }
 
 enum HandleConflictBehavior {

diff --git a/proto/meta.proto b/proto/meta.proto
@@ -90,6 +90,25 @@ message TableFragments {
     // so we pre-generate and store it here, this member will only be initialized when creating the Fragment
     // and modified when creating the mv-on-mv
     repeated uint32 upstream_fragment_ids = 7;
+
+    // If a materialize view, sink, or table has a node_label, its actors can only be scheduled 
+    // on compute nodes with that label.
+    // If it does not have a node_label (empty map or null value) it can be scheduled on any 
+    // compute node without a label. The node has to have both a matching key and value.
+    // E.g. {"some":"value"} can be scheduled on a node with the labels
+    // { 
+    //   "other":"thing",
+    //   "some":"value"
+    // }
+    // but {"some":"thing"} can not be scheduled on that node.
+    // A materialized view or sink or table with an empty node_labels map can only be scheduled on nodes with 
+    // empty node_labels map. 
+    // A node with an empty node_labels map can only host streaming jobs with an empty node_labels map. 
+    map<string, string> node_labels = 101;
+
+    // If this is a materialized view: True if backfill is done, else false.
+    // If this is a regular table: Always true.
+    bool backfill_done = 102;
   }
   uint32 table_id = 1;
   State state = 2;