add bound to SourceProperties

src/connector/src/source/base.rs

@@ -48,6 +48,7 @@ pub(crate) use crate::source::common::CommonSplitReader;
 use crate::source::filesystem::opendal_source::OpendalS3Properties;
 use crate::source::filesystem::{FsPageItem, GcsProperties, S3Properties};
 use crate::source::monitor::EnumeratorMetrics;
+use crate::with_options::WithOptions;
 use crate::{
     dispatch_source_prop, dispatch_split_impl, for_all_sources, impl_connector_properties,
     impl_split, match_source_name_str,
@@ -61,7 +62,7 @@ pub trait TryFromHashmap: Sized {
     fn try_from_hashmap(props: HashMap<String, String>) -> Result<Self>;
 }
 
-pub trait SourceProperties: TryFromHashmap + Clone {
+pub trait SourceProperties: TryFromHashmap + Clone + WithOptions {
     const SOURCE_NAME: &'static str;
     type Split: SplitMetaData + TryFrom<SplitImpl, Error = anyhow::Error> + Into<SplitImpl>;
     type SplitEnumerator: SplitEnumerator<Properties = Self, Split = Self::Split>;

src/connector/src/with_options.rs

@@ -17,6 +17,9 @@ use std::collections::HashMap;
 /// Dummy trait for `WITH` options. Only for `#[derive(WithOptions)]`, should not be used manually.
 ///
 /// This is used to ensure the `WITH` options types have reasonable structure.
+///
+/// TODO: add this bound for sink. There's a `SourceProperties` trait for sources, but no similar
+/// things for sinks.
 pub trait WithOptions {
     #[doc(hidden)]
     #[inline(always)]