fix(postgres-cdc): fix validation of PK with uppercase (#16793)

risingwavelabs · May 17, 2024 · 30f1ebe · 30f1ebe
1 parent 5ef4b28
commit 30f1ebe
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/e2e_test/source/cdc/cdc.load.slt b/e2e_test/source/cdc/cdc.load.slt
@@ -161,7 +161,7 @@ create table shipments_2 (
 # Test user-provided publication
 statement ok
 create table t1_rw (
-    v1 int primary key,
+    "V1" int primary key,
     v3 varchar
 ) with (
   connector = 'postgres-cdc',

diff --git a/e2e_test/source/cdc/postgres_cdc.sql b/e2e_test/source/cdc/postgres_cdc.sql
@@ -31,8 +31,8 @@ INSERT INTO person VALUES (1001, 'peter white', '[email protected]', '1781 2313
 INSERT INTO person VALUES (1002, 'sarah spencer', '[email protected]', '3453 4987 9481 6270', 'los angeles');
 
 create schema abs;
-create table abs.t1 (v1 int primary key, v2 double precision, v3 varchar, v4 numeric);
-create publication my_publicaton for table abs.t1 (v1, v3);
+create table abs.t1 ("V1" int primary key, v2 double precision, v3 varchar, v4 numeric);
+create publication my_publicaton for table abs.t1 ("V1", v3);
 insert into abs.t1 values (1, 1.1, 'aaa', '5431.1234');
 
 

diff --git a/...ector-service/src/main/java/com/risingwave/connector/source/common/PostgresValidator.java b/...ector-service/src/main/java/com/risingwave/connector/source/common/PostgresValidator.java
@@ -180,8 +180,7 @@ private void validateTableSchema() throws SQLException {
             var pkFields = new HashSet<String>();
             while (res.next()) {
                 var name = res.getString(1);
-                // RisingWave always use lower case for column name
-                pkFields.add(name.toLowerCase());
+                pkFields.add(name);
             }
 
             if (!ValidatorUtils.isPrimaryKeyMatch(tableSchema, pkFields)) {