make it private

Signed-off-by: Bugen Zhao <[email protected]>
risingwavelabs · Nov 13, 2024 · 3026006 · 3026006
1 parent ed5ea19
commit 3026006
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/frontend/src/optimizer/plan_node/logical_scan.rs b/src/frontend/src/optimizer/plan_node/logical_scan.rs
@@ -495,9 +495,7 @@ impl ToBatch for LogicalScan {
 
         if !new.indexes().is_empty() {
             let index_selection_rule = IndexSelectionRule::create();
-            if let ApplyResult::Ok(applied) =
-                index_selection_rule.apply(new.clone().into())
-            {
+            if let ApplyResult::Ok(applied) = index_selection_rule.apply(new.clone().into()) {
                 if let Some(scan) = applied.as_logical_scan() {
                     // covering index
                     return required_order.enforce_if_not_satisfies(scan.to_batch()?);

diff --git a/src/frontend/src/optimizer/rule/mod.rs b/src/frontend/src/optimizer/rule/mod.rs
@@ -67,7 +67,9 @@ where
 }
 
 /// An one-to-one transform for the [`PlanNode`](super::plan_node::PlanNode).
-pub trait InfallibleRule: Send + Sync + Description {
+///
+/// It's a convenient trait to implement [`FallibleRule`], thus made available only within this module.
+trait InfallibleRule: Send + Sync + Description {
     /// Apply the rule to the plan node.
     ///
     /// - Returns `Some` if the apply is successful.
@@ -95,7 +97,7 @@ where
     T: InfallibleRule,
 {
     fn apply(&self, plan: PlanRef) -> ApplyResult {
-        match self.apply(plan) {
+        match InfallibleRule::apply(self, plan) {
             Some(plan) => ApplyResult::Ok(plan),
             None => ApplyResult::NotApplicable,
         }