Skip to content

Commit

Permalink
remove unnecessary Frame method
Browse files Browse the repository at this point in the history
Signed-off-by: Richard Chien <[email protected]>
  • Loading branch information
stdrc committed Jan 9, 2024
1 parent fd768da commit 2d864d6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
4 changes: 0 additions & 4 deletions src/expr/core/src/window_function/call.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@ impl Frame {
exclusion,
}
}

pub fn is_unbounded(&self) -> bool {
self.bounds.is_unbounded()
}
}

impl Frame {
Expand Down
5 changes: 4 additions & 1 deletion src/stream/src/executor/over_window/general.rs
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,10 @@ impl<S: StateStore> OverWindowExecutor<S> {
let input_info = args.input.info();
let input_schema = &input_info.schema;

let has_unbounded_frame = args.calls.iter().any(|call| call.frame.is_unbounded());
let has_unbounded_frame = args
.calls
.iter()
.any(|call| call.frame.bounds.is_unbounded());
let cache_policy = if has_unbounded_frame {
// For unbounded frames, we finally need all entries of the partition in the cache,
// so for simplicity we just use full cache policy for these cases.
Expand Down

0 comments on commit 2d864d6

Please sign in to comment.