Skip to content

Commit

Permalink
chore(storage): remove unused disk object store impl (#9983)
Browse files Browse the repository at this point in the history
  • Loading branch information
Li0k authored May 24, 2023
1 parent e90d704 commit 2d7978d
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 945 deletions.
15 changes: 0 additions & 15 deletions src/common/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -353,13 +353,6 @@ pub struct StorageConfig {
#[serde(default = "default::storage::disable_remote_compactor")]
pub disable_remote_compactor: bool,

#[serde(default = "default::storage::enable_local_spill")]
pub enable_local_spill: bool,

/// Local object store root. We should call `get_local_object_store` to get the object store.
#[serde(default = "default::storage::local_object_store")]
pub local_object_store: String,

/// Number of tasks shared buffer can upload in parallel.
#[serde(default = "default::storage::share_buffer_upload_concurrency")]
pub share_buffer_upload_concurrency: usize,
Expand Down Expand Up @@ -675,14 +668,6 @@ mod default {
false
}

pub fn enable_local_spill() -> bool {
true
}

pub fn local_object_store() -> String {
"tempdisk".to_string()
}

pub fn share_buffer_upload_concurrency() -> usize {
8
}
Expand Down
2 changes: 0 additions & 2 deletions src/config/example.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ share_buffer_compaction_worker_threads_number = 4
imm_merge_threshold = 4
write_conflict_detection_enabled = true
disable_remote_compactor = false
enable_local_spill = true
local_object_store = "tempdisk"
share_buffer_upload_concurrency = 8
sstable_id_remote_fetch_number = 10
min_sst_size_for_streaming_upload = 33554432
Expand Down
Loading

0 comments on commit 2d7978d

Please sign in to comment.