Skip to content

Commit

Permalink
fix: donot use opendal for s3 by default (#16017)
Browse files Browse the repository at this point in the history
  • Loading branch information
hzxa21 authored Mar 29, 2024
1 parent f756b72 commit 2c869b4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/common/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1729,7 +1729,7 @@ pub mod default {
}

pub mod developer {
use crate::util::env_var::env_var_is_false_or;
use crate::util::env_var::env_var_is_true_or;
const RW_USE_OPENDAL_FOR_S3: &str = "RW_USE_OPENDAL_FOR_S3";

pub fn object_store_retry_unknown_service_error() -> bool {
Expand All @@ -1745,7 +1745,7 @@ pub mod default {
// The reason why we use !env_var_is_false_or(RW_USE_OPENDAL_FOR_S3, false) here is
// 1. Maintain compatibility so that there is no behavior change in cluster with RW_USE_OPENDAL_FOR_S3 set.
// 2. Change the default behavior to use opendal for s3 if RW_USE_OPENDAL_FOR_S3 is not set.
!env_var_is_false_or(RW_USE_OPENDAL_FOR_S3, false)
env_var_is_true_or(RW_USE_OPENDAL_FOR_S3, false)
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/config/example.toml
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ identity_resolution_timeout_s = 5
[storage.object_store.s3.developer]
object_store_retry_unknown_service_error = false
object_store_retryable_service_error_codes = ["SlowDown", "TooManyRequests"]
use_opendal = true
use_opendal = false

[system]
barrier_interval_ms = 1000
Expand Down

0 comments on commit 2c869b4

Please sign in to comment.