Skip to content

Commit

Permalink
fix(simulation): do not run background ddl on skipped tests (#17440)
Browse files Browse the repository at this point in the history
  • Loading branch information
kwannoel authored Jun 25, 2024
1 parent e5c0a42 commit 2adcca3
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/tests/simulation/src/slt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ use anyhow::{bail, Result};
use itertools::Itertools;
use rand::{thread_rng, Rng, SeedableRng};
use rand_chacha::ChaChaRng;
use sqllogictest::{ParallelTestError, QueryExpect, Record, StatementExpect};
use sqllogictest::{Condition, ParallelTestError, QueryExpect, Record, StatementExpect};

use crate::client::RisingWave;
use crate::cluster::{Cluster, KillOpts};
Expand Down Expand Up @@ -274,6 +274,11 @@ pub async fn run_slt_task(
} = &record
&& matches!(cmd, SqlCmd::CreateMaterializedView { .. })
&& !manual_background_ddl_enabled
&& conditions.iter().all(|c| {
*c != Condition::SkipIf {
label: "madsim".to_string(),
}
})
{
let background_ddl_setting = rng.gen_bool(background_ddl_rate);
let set_background_ddl = Record::Statement {
Expand Down

0 comments on commit 2adcca3

Please sign in to comment.