Skip to content

Commit

Permalink
fix(ci): wait for the standalone/single-node process to be killed bef…
Browse files Browse the repository at this point in the history
…ore starting again (#18010)

Signed-off-by: Bugen Zhao <[email protected]>
  • Loading branch information
BugenZhao authored Aug 13, 2024
1 parent 58b3f41 commit 2844ad2
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 11 deletions.
2 changes: 1 addition & 1 deletion ci/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ENV LANG en_US.utf8
# Use AWS ubuntu mirror
RUN sed -i 's|http://archive.ubuntu.com/ubuntu|http://us-east-2.ec2.archive.ubuntu.com/ubuntu/|g' /etc/apt/sources.list
RUN apt-get update -yy && \
DEBIAN_FRONTEND=noninteractive apt-get -y install sudo make build-essential cmake protobuf-compiler curl parallel python3 python3-pip python3-venv software-properties-common \
DEBIAN_FRONTEND=noninteractive apt-get -y install sudo make build-essential cmake protobuf-compiler curl parallel python3 python3-pip python3-venv software-properties-common psmisc \
openssl libssl-dev libsasl2-dev libcurl4-openssl-dev pkg-config bash openjdk-17-jdk wget unzip git tmux lld postgresql-client kcat netcat-openbsd mysql-client \
maven zstd libzstd-dev locales \
python3.12 python3.12-dev \
Expand Down
2 changes: 1 addition & 1 deletion ci/build-ci-image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ cat ../rust-toolchain
# shellcheck disable=SC2155

# REMEMBER TO ALSO UPDATE ci/docker-compose.yml
export BUILD_ENV_VERSION=v20240731
export BUILD_ENV_VERSION=v20240812

export BUILD_TAG="public.ecr.aws/w1p7b4n3/rw-build-env:${BUILD_ENV_VERSION}"

Expand Down
10 changes: 5 additions & 5 deletions ci/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ services:
retries: 5

source-test-env:
image: public.ecr.aws/w1p7b4n3/rw-build-env:v20240731
image: public.ecr.aws/w1p7b4n3/rw-build-env:v20240812
depends_on:
- mysql
- sqlserver-server
Expand All @@ -85,7 +85,7 @@ services:
- ..:/risingwave

sink-test-env:
image: public.ecr.aws/w1p7b4n3/rw-build-env:v20240731
image: public.ecr.aws/w1p7b4n3/rw-build-env:v20240812
depends_on:
- mysql
- db
Expand All @@ -108,12 +108,12 @@ services:


rw-build-env:
image: public.ecr.aws/w1p7b4n3/rw-build-env:v20240731
image: public.ecr.aws/w1p7b4n3/rw-build-env:v20240812
volumes:
- ..:/risingwave

ci-flamegraph-env:
image: public.ecr.aws/w1p7b4n3/rw-build-env:v20240731
image: public.ecr.aws/w1p7b4n3/rw-build-env:v20240812
# NOTE(kwannoel): This is used in order to permit
# syscalls for `nperf` (perf_event_open),
# so it can do CPU profiling.
Expand All @@ -124,7 +124,7 @@ services:
- ..:/risingwave

regress-test-env:
image: public.ecr.aws/w1p7b4n3/rw-build-env:v20240731
image: public.ecr.aws/w1p7b4n3/rw-build-env:v20240812
depends_on:
db:
condition: service_healthy
Expand Down
3 changes: 1 addition & 2 deletions ci/scripts/single-node-utils.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ start_single_node() {
}

stop_single_node() {
pkill risingwave
killall --wait risingwave
rm -rf "$HOME/.risingwave/state_store"
rm -rf "$HOME/.risingwave/meta_store"
}
Expand Down Expand Up @@ -47,7 +47,6 @@ wait_single_node() {

restart_single_node() {
stop_single_node
sleep 5
start_single_node "$PREFIX_LOG"/single-node-restarted.log &
wait_single_node
}
3 changes: 1 addition & 2 deletions ci/scripts/standalone-utils.sh
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ start_standalone() {
}

stop_standalone() {
pkill standalone
killall --wait standalone
}

wait_standalone() {
Expand All @@ -101,7 +101,6 @@ wait_standalone() {

restart_standalone() {
stop_standalone
sleep 5
start_standalone "$PREFIX_LOG"/standalone-restarted.log &
wait_standalone
}

0 comments on commit 2844ad2

Please sign in to comment.