handle possible panic case when building the regex

risingwavelabs · Sep 15, 2023 · 2576866 · 2576866
1 parent 0833968
commit 2576866
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/e2e_test/batch/basic/func.slt.part b/e2e_test/batch/basic/func.slt.part
@@ -594,6 +594,9 @@ select regexp_replace('foobarXaz', '(?<!X)a', 'X');
 ----
 foobXrXaz
 
+query error Parsing error at position 2: Unknown group flag: (?1
+select regexp_replace('foobarXaz', '(?1:123)', 'X');
+
 query T
 select regexp_count('ABCABCAXYaxy', 'A.');
 ----

diff --git a/src/expr/src/vector_op/regexp.rs b/src/expr/src/vector_op/regexp.rs
@@ -40,7 +40,9 @@ impl RegexpContext {
         };
 
         Ok(Self {
-            regex: RegexBuilder::new(&origin).build().unwrap(),
+            regex: RegexBuilder::new(&origin)
+                .build()
+                .map_err(|e| ExprError::Parse(e.to_string().into()))?,
             global: options.global,
             replacement: make_replacement(replacement),
         })