Skip to content

Commit

Permalink
refine comments
Browse files Browse the repository at this point in the history
Signed-off-by: TennyZhuang <[email protected]>
  • Loading branch information
TennyZhuang committed Feb 23, 2024
1 parent 6dd22b3 commit 2472ba3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/stream/src/executor/temporal_join.rs
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ impl<K: HashKey, S: StateStore, const T: JoinTypePrimitive> TemporalJoinExecutor
yield Message::Watermark(watermark.with_idx(output_watermark_col_idx));
}
InternalMessage::Chunk(chunk) => {
// Joined result without evaluating other conditions.
// Joined result without evaluating non-lookup conditions.
let st1 = {
#[try_stream]
async {
Expand Down Expand Up @@ -470,7 +470,7 @@ impl<K: HashKey, S: StateStore, const T: JoinTypePrimitive> TemporalJoinExecutor
#[for_await]
for item in st1 {
let (chunk, row_matched) = item?;
// check other join conditions
// check non-lookup join conditions
if !row_matched.is_empty()
&& let Some(ref cond) = self.condition
{
Expand Down

0 comments on commit 2472ba3

Please sign in to comment.