refine inf,-inf convert

risingwavelabs · Mar 26, 2024 · 22a15bf · 22a15bf
1 parent 55c1261
commit 22a15bf
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 9 deletions.
diff --git a/e2e_test/iceberg/test_case/no_partition_append_only.toml b/e2e_test/iceberg/test_case/no_partition_append_only.toml
@@ -28,8 +28,8 @@ verify_sql = 'SELECT * FROM demo_db.demo_table ORDER BY id ASC'
 verify_data = """
 1,1,1000,1.1,1.11,1-1,true,2022-03-11,2022-03-11 01:00:00+00:00,2022-03-11 01:00:00,1.11
 2,2,2000,2.2,2.22,2-2,false,2022-03-12,2022-03-12 02:00:00+00:00,2022-03-12 02:00:00,2.22
-3,3,3000,3.3,3.33,3-3,true,2022-03-13,2022-03-13 03:00:00+00:00,2022-03-13 03:00:00,none
-4,4,4000,4.4,4.44,4-4,false,2022-03-14,2022-03-14 04:00:00+00:00,2022-03-14 04:00:00,none
+3,3,3000,3.3,3.33,3-3,true,2022-03-13,2022-03-13 03:00:00+00:00,2022-03-13 03:00:00,99999.99999
+4,4,4000,4.4,4.44,4-4,false,2022-03-14,2022-03-14 04:00:00+00:00,2022-03-14 04:00:00,-99999.99999
 5,5,5000,5.5,5.55,5-5,true,2022-03-15,2022-03-15 05:00:00+00:00,2022-03-15 05:00:00,none
 """
 

diff --git a/e2e_test/iceberg/test_case/partition_append_only.toml b/e2e_test/iceberg/test_case/partition_append_only.toml
@@ -30,8 +30,8 @@ verify_sql = 'SELECT * FROM demo_db.demo_table ORDER BY id ASC'
 verify_data = """
 1,1,1000,1.1,1.11,1-1,true,2022-03-11,2022-03-11 01:00:00+00:00,2022-03-11 01:00:00,1.11
 2,2,2000,2.2,2.22,2-2,false,2022-03-12,2022-03-12 02:00:00+00:00,2022-03-12 02:00:00,2.22
-3,3,3000,3.3,3.33,3-3,true,2022-03-13,2022-03-13 03:00:00+00:00,2022-03-13 03:00:00,none
-4,4,4000,4.4,4.44,4-4,false,2022-03-14,2022-03-14 04:00:00+00:00,2022-03-14 04:00:00,none
+3,3,3000,3.3,3.33,3-3,true,2022-03-13,2022-03-13 03:00:00+00:00,2022-03-13 03:00:00,9999999999
+4,4,4000,4.4,4.44,4-4,false,2022-03-14,2022-03-14 04:00:00+00:00,2022-03-14 04:00:00,-9999999999
 5,5,5000,5.5,5.55,5-5,true,2022-03-15,2022-03-15 05:00:00+00:00,2022-03-15 05:00:00,none
 """
 

diff --git a/src/common/src/array/arrow/arrow_iceberg.rs b/src/common/src/array/arrow/arrow_iceberg.rs
@@ -64,8 +64,15 @@ impl ToArrowArrayWithTypeConvert for IcebergArrowConvert {
                         };
                         Some(value)
                     }
-                    crate::array::Decimal::PositiveInf => None,
-                    crate::array::Decimal::NegativeInf => None,
+                    // For Inf, we replace them with the max/min value within the precision.
+                    crate::array::Decimal::PositiveInf => {
+                        let max_value = 10_i128.pow(precision as u32) - 1;
+                        Some(max_value as i128)
+                    },
+                    crate::array::Decimal::NegativeInf => {
+                        let max_value = 10_i128.pow(precision as u32) - 1;
+                        Some(-max_value as i128)
+                    },
                     crate::array::Decimal::NaN => None,
                 })
             })
@@ -156,14 +163,14 @@ mod test {
             Some(Decimal::Normalized("123.4".parse().unwrap())),
             Some(Decimal::Normalized("123.456".parse().unwrap())),
         ]);
-        let ty = arrow_schema::DataType::Decimal128(38, 3);
+        let ty = arrow_schema::DataType::Decimal128(6, 3);
         let arrow_array = IcebergArrowConvert.decimal_to_arrow(&ty, &array).unwrap();
         let expect_array = Arc::new(
             arrow_array::Decimal128Array::from(vec![
                 None,
                 None,
-                None,
-                None,
+                Some(999999),
+                Some(-999999),
                 Some(123400),
                 Some(123456),
             ])