feat(storage): adapt to foyer without ring buffer and try avoid copy (#…

…13987) Signed-off-by: MrCroxx <[email protected]>
risingwavelabs · Dec 19, 2023 · 1cacc07 · 1cacc07
1 parent bbc5bd8
commit 1cacc07
Show file tree

Hide file tree

Showing 5 changed files with 377 additions and 116 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/src/storage/Cargo.toml b/src/storage/Cargo.toml
@@ -26,7 +26,7 @@ dyn-clone = "1.0.14"
 either = "1"
 enum-as-inner = "0.6"
 fail = "0.5"
-foyer = "0.2"
+foyer = "0.3"
 futures = { version = "0.3", default-features = false, features = ["alloc"] }
 futures-async-stream = { workspace = true }
 hex = "0.4"

diff --git a/src/storage/src/hummock/event_handler/refiller.rs b/src/storage/src/hummock/event_handler/refiller.rs
@@ -344,7 +344,7 @@ impl CacheRefillTask {
     fn get_units_to_refill_by_inheritance(
         context: &CacheRefillContext,
         ssts: &[TableHolder],
-        parent_ssts: &[impl Deref<Target = Box<Sstable>>],
+        parent_ssts: &[impl Deref<Target = Sstable>],
     ) -> HashSet<SstableUnit> {
         let mut res = HashSet::default();
 
@@ -606,6 +606,7 @@ impl CacheRefillTask {
                             bytes,
                             uncompressed_capacity: writer.weight() - writer.key().serialized_len(),
                         };
+
                         writer.force();
                         // TODO(MrCroxx): compress if raw is not compressed?
                         // skip compression for it may already be compressed.