fix(protobuf): store offset and limit in uint64 in TopNNode a…

…nd `LimitNode` (#4666) fix Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
risingwavelabs · Aug 16, 2022 · 16cd164 · 16cd164
1 parent 65c2a24
commit 16cd164
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/proto/batch_plan.proto b/proto/batch_plan.proto
@@ -91,13 +91,13 @@ message OrderByNode {
 
 message TopNNode {
   repeated plan_common.ColumnOrder column_orders = 1;
-  uint32 limit = 2;
-  uint32 offset = 3;
+  uint64 limit = 2;
+  uint64 offset = 3;
 }
 
 message LimitNode {
-  uint32 limit = 1;
-  uint32 offset = 2;
+  uint64 limit = 1;
+  uint64 offset = 2;
 }
 
 message NestedLoopJoinNode {

diff --git a/src/frontend/src/optimizer/plan_node/batch_limit.rs b/src/frontend/src/optimizer/plan_node/batch_limit.rs
@@ -80,8 +80,8 @@ impl ToDistributedBatch for BatchLimit {
 impl ToBatchProst for BatchLimit {
     fn to_batch_prost_body(&self) -> NodeBody {
         NodeBody::Limit(LimitNode {
-            limit: self.logical.limit() as u32,
-            offset: self.logical.offset() as u32,
+            limit: self.logical.limit() as u64,
+            offset: self.logical.offset() as u64,
         })
     }
 }

diff --git a/src/frontend/src/optimizer/plan_node/batch_topn.rs b/src/frontend/src/optimizer/plan_node/batch_topn.rs
@@ -83,8 +83,8 @@ impl ToBatchProst for BatchTopN {
     fn to_batch_prost_body(&self) -> NodeBody {
         let column_orders = self.logical.topn_order().to_protobuf(&self.base.schema);
         NodeBody::TopN(TopNNode {
-            limit: self.logical.limit() as u32,
-            offset: self.logical.offset() as u32,
+            limit: self.logical.limit() as u64,
+            offset: self.logical.offset() as u64,
             column_orders,
         })
     }