feat(common): add cmp_by to Sentinelled (#14578)

Signed-off-by: Richard Chien <[email protected]>
risingwavelabs · Jan 16, 2024 · 08da611 · 08da611
1 parent da5e90d
commit 08da611
Showing 1 changed file with 18 additions and 10 deletions.
diff --git a/src/common/src/types/sentinel.rs b/src/common/src/types/sentinel.rs
@@ -37,6 +37,23 @@ impl<T> Sentinelled<T> {
     pub fn is_sentinel(&self) -> bool {
         matches!(self, Self::Smallest | Self::Largest)
     }
+
+    pub fn cmp_by(
+        &self,
+        other: &Self,
+        cmp_fn: impl FnOnce(&T, &T) -> std::cmp::Ordering,
+    ) -> std::cmp::Ordering {
+        use Sentinelled::*;
+        match (self, other) {
+            (Smallest, Smallest) => std::cmp::Ordering::Equal,
+            (Smallest, _) => std::cmp::Ordering::Less,
+            (_, Smallest) => std::cmp::Ordering::Greater,
+            (Largest, Largest) => std::cmp::Ordering::Equal,
+            (Largest, _) => std::cmp::Ordering::Greater,
+            (_, Largest) => std::cmp::Ordering::Less,
+            (Normal(a), Normal(b)) => cmp_fn(a, b),
+        }
+    }
 }
 
 impl<T> PartialOrd for Sentinelled<T>
@@ -53,16 +70,7 @@ where
     T: Ord,
 {
     fn cmp(&self, other: &Self) -> std::cmp::Ordering {
-        use Sentinelled::*;
-        match (self, other) {
-            (Smallest, Smallest) => std::cmp::Ordering::Equal,
-            (Smallest, _) => std::cmp::Ordering::Less,
-            (_, Smallest) => std::cmp::Ordering::Greater,
-            (Largest, Largest) => std::cmp::Ordering::Equal,
-            (Largest, _) => std::cmp::Ordering::Greater,
-            (_, Largest) => std::cmp::Ordering::Less,
-            (Normal(a), Normal(b)) => a.cmp(b),
-        }
+        self.cmp_by(other, T::cmp)
     }
 }