add server.id for both table & source

Signed-off-by: xxchan <[email protected]>
risingwavelabs · Nov 1, 2024 · 06fd5cb · 06fd5cb
1 parent 299809c
commit 06fd5cb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/e2e_test/source_inline/cdc/mysql/mysql_create_drop.slt.serial b/e2e_test/source_inline/cdc/mysql/mysql_create_drop.slt.serial
@@ -45,7 +45,6 @@ create source s with (
   username = 'shared-cdc',
   password = 'abcdef',
   database.name = 'testdb1',
-  server.id = '114514'
 );
 
 sleep 2s

diff --git a/src/frontend/src/handler/create_source.rs b/src/frontend/src/handler/create_source.rs
@@ -1466,7 +1466,7 @@ pub fn bind_connector_props(
                 .to_string(),
         );
     }
-    if !is_create_source && with_properties.is_mysql_cdc_connector() {
+    if with_properties.is_mysql_cdc_connector() {
         // Generate a random server id for mysql cdc source if needed
         // `server.id` (in the range from 1 to 2^32 - 1). This value MUST be unique across whole replication
         // group (that is, different from any other server id being used by any master or slave)