cleanup todos

Signed-off-by: Bugen Zhao <[email protected]>
risingwavelabs · Feb 5, 2024 · 04f17ec · 04f17ec
1 parent 1bef70b
commit 04f17ec
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/src/connector/src/parser/mod.rs b/src/connector/src/parser/mod.rs
@@ -21,7 +21,7 @@ pub use avro::AvroParserConfig;
 pub use canal::*;
 use csv_parser::CsvParser;
 pub use debezium::*;
-use futures::{Future, TryFutureExt, TryStreamExt};
+use futures::{Future, TryFutureExt};
 use futures_async_stream::try_stream;
 pub use json_parser::*;
 pub use protobuf::*;
@@ -572,15 +572,13 @@ impl<P: ByteStreamSourceParser> P {
 
         // The parser stream will be long-lived. We use `instrument_with` here to create
         // a new span for the polling of each chunk.
-        into_chunk_stream(self, data_stream)
-            .instrument_with(move || {
-                tracing::info_span!(
-                    "source_parse_chunk",
-                    actor_id = source_info.actor_id,
-                    source_id = source_info.source_id.table_id()
-                )
-            })
-            .map_err(Into::into) // TODO(eh): remove this
+        into_chunk_stream(self, data_stream).instrument_with(move || {
+            tracing::info_span!(
+                "source_parse_chunk",
+                actor_id = source_info.actor_id,
+                source_id = source_info.source_id.table_id()
+            )
+        })
     }
 }
 
@@ -730,7 +728,6 @@ async fn into_chunk_stream<P: ByteStreamSourceParser>(mut parser: P, data_stream
 }
 
 pub trait AccessBuilder {
-    // TODO(eh)
     async fn generate_accessor(&mut self, payload: Vec<u8>) -> anyhow::Result<AccessImpl<'_, '_>>;
 }
 

diff --git a/src/connector/src/parser/protobuf/parser.rs b/src/connector/src/parser/protobuf/parser.rs
@@ -341,7 +341,6 @@ fn recursive_parse_json(
     serde_json::Value::Object(ret)
 }
 
-// TODO(eh): should use `AccessError`
 pub fn from_protobuf_value(
     field_desc: &FieldDescriptor,
     value: &Value,