Skip to content

Commit

Permalink
fix comment
Browse files Browse the repository at this point in the history
  • Loading branch information
yuhao-su committed Sep 18, 2023
1 parent 77dedc6 commit 031cf92
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
4 changes: 0 additions & 4 deletions src/common/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -924,10 +924,6 @@ pub mod default {
pub fn telemetry_enabled() -> bool {
true
}

pub fn manually_dump_heap_profile_dir() -> String {
"".to_string()
}
}

pub mod storage {
Expand Down
4 changes: 2 additions & 2 deletions src/common/src/heap_profiling/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

pub const MANUALLY_DUMP_MID_NAME: &str = "manually-dump.compute.dump";
pub const AUTO_DUMP_MID_NAME: &str = "auto-dump.compute.dump";
pub const MANUALLY_DUMP_MID_NAME: &str = "manually-dump.compute.heap";
pub const AUTO_DUMP_MID_NAME: &str = "auto-dump.compute.heap";
pub const COLLAPSED_SUFFIX: &str = "collapsed";

pub mod jeprof;
2 changes: 1 addition & 1 deletion src/compute/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ pub struct ComputeNodeOpts {
/// Enable heap profile dump when memory usage is high.
#[clap(long, env = "RW_HEAP_PROFILING_DIR")]
#[override_opts(path = server.heap_profiling.dir)]
pub heap_profiling: Option<String>,
pub heap_profiling_dir: Option<String>,

#[clap(long, env = "RW_OBJECT_STORE_STREAMING_READ_TIMEOUT_MS", value_enum)]
#[override_opts(path = storage.object_store_streaming_read_timeout_ms)]
Expand Down
2 changes: 1 addition & 1 deletion src/compute/src/rpc/service/monitor_service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ impl MonitorService for MonitorServiceImpl {
}

let time_prefix = chrono::Local::now().format("%Y-%m-%d-%H-%M-%S").to_string();
let file_name = format!("{}.{}\0", time_prefix, AUTO_DUMP_MID_NAME);
let file_name = format!("{}.{}\0", time_prefix, MANUALLY_DUMP_MID_NAME);
let arg_dir = request.into_inner().get_dir().clone();
let dir = PathBuf::from(if arg_dir.is_empty() {
&self.server_config.heap_profiling.dir
Expand Down

0 comments on commit 031cf92

Please sign in to comment.