Skip to content

Commit

Permalink
change comments
Browse files Browse the repository at this point in the history
  • Loading branch information
CAJan93 committed Jul 15, 2024
1 parent 39e75f0 commit 003ac47
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 13 deletions.
9 changes: 5 additions & 4 deletions proto/catalog.proto
Original file line number Diff line number Diff line change
Expand Up @@ -406,16 +406,17 @@ message Table {
// notification service.
TableVersion version = 100;

// If a MV/sink/table has a node_label, its actors can only be scheduled on CNs with
// that label. If a MV does not have a node_label it can be scheduled on any
// CN without a label. The node has to have both a matching key and value.
// If a materialize view, sink, or table has a node_label, its actors can only be scheduled
// on compute nodes with that label.
// If a it does not have a node_label it can be scheduled on any
// Compute node without a label. The node has to have both a matching key and value.
// E.g. {"some":"value"} can be scheduled on a node with the labels
// {
// "other":"thing",
// "some":"value"
// }
// but {"some":"thing"} can not be scheduled on that node.
// A MV/sink/table with an empty node_labels map can only be scheduled on nodes with
// A materialized view or sink or table with an empty node_labels map can only be scheduled on nodes with
// empty node_labels map, but a node with empty node_labels can host anything.
map<string, string> node_labels = 101;
}
Expand Down
8 changes: 4 additions & 4 deletions proto/common.proto
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,17 @@ message WorkerNode {
optional uint64 started_at = 9;

// Meta may assign labels to worker nodes to partition workload by label.
// This is used for serverless backfilling of MVs.
// This is used for serverless backfilling of materialized views.
// If a WorkerNode has labels set it indicates that this node only accepts certain work.
// If a WorkerNode has no labels set it indicates that this node only any work.
// The MV has to have both a matching key and value to be scheduled on a node.
// If a WorkerNode has no labels set it indicates that this node accepts any work.
// The materialized view has to have both a matching key and value to be scheduled on a node.
// E.g. {"some":"value"} can be scheduled on a node with the labels
// {
// "other":"thing",
// "some":"value"
// }
// but {"some":"thing"} can not be scheduled on that node.
// Worker nodes with an empty node_labels map can host any MV/sink/table.
// Worker nodes with an empty node_labels map can host any materialized view or sink or table.
map<string, string> node_labels = 10;
}

Expand Down
4 changes: 2 additions & 2 deletions proto/ddl_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ message CreateMaterializedViewRequest {
catalog.Table materialized_view = 1;
stream_plan.StreamFragmentGraph fragment_graph = 2;

// If SERVERLESS, the MV should be created using serverless backfill
// For that the controller will create a new CN, which does backfilling and then is deleted.
// If SERVERLESS, the materialized view should be created using serverless backfill
// For that the controller will create a new compute node, which does backfilling and then is deleted.
// May alleviate pressure on the cluster during backfill process.
enum BackfillType {
REGULAR = 0;
Expand Down
5 changes: 2 additions & 3 deletions proto/meta.proto
Original file line number Diff line number Diff line change
Expand Up @@ -546,14 +546,13 @@ message TableParallelism {
}
}

// overwrite the MV/table/sink with the given id
// overwrite the materialized view/table/sink with the given id
// Change a streaming job in place. You cannot use this to create a new streaming job
message UpdateStreamingJobRequest {
// Id of the MV or sink which we want to update
// Id of the materialized view, table, or sink which we want to update
uint32 id = 1;

oneof streaming_job {
// the new MV or table
catalog.Table table = 2;
catalog.Sink sinks = 3;
}
Expand Down

0 comments on commit 003ac47

Please sign in to comment.