Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enforce recreating (force updating) objects when operator versi… #736

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

arkbriar
Copy link
Collaborator

…on changes

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Before the change, the EnableForceUpdate feature gate won't work even if there's a conflict when the object is created by the same version of operator. Though the feature was intended to address inconsistency after upgrading operator, it's now getting confusing as feat: turn the feature gate EnableForceUpdate on by default #727 is merged.
  • The PR changes the behaviour to let operator automatically address inconsistency problems on operator version changes, and do force updates when the feature gate is on.

Checklist

  • I have written the necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@arkbriar arkbriar requested review from wjf3121 and xuhui-lu October 18, 2024 06:24
@arkbriar arkbriar requested a review from a team as a code owner October 18, 2024 06:24
@arkbriar
Copy link
Collaborator Author

A patch release will be created once the PR's merged.

@arkbriar arkbriar changed the title feat: enforce recreation (force updating) objects when operator versi… feat: enforce recreating (force updating) objects when operator versi… Oct 18, 2024
Copy link
Contributor

@xuhui-lu xuhui-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkbriar arkbriar enabled auto-merge October 18, 2024 06:55
@arkbriar arkbriar added this pull request to the merge queue Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.42%. Comparing base (df47bd0) to head (97620f2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/manager/risingwave_controller_manager_impl.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   55.43%   55.42%   -0.02%     
==========================================
  Files          40       40              
  Lines        6757     6759       +2     
==========================================
  Hits         3746     3746              
- Misses       2884     2886       +2     
  Partials      127      127              
Flag Coverage Δ
unittests 55.42% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 6e0081d Oct 18, 2024
10 of 12 checks passed
@arkbriar arkbriar deleted the shunjie/change-the-behaviour-of-force-updating branch October 18, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants