Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared source #69

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Add shared source #69

merged 5 commits into from
Nov 22, 2024

Conversation

WanYixian
Copy link
Collaborator

@WanYixian WanYixian commented Nov 20, 2024

Description

  • Turn the draft into technical doc
  • Special thanks to Nika for providing the images

Related Code PR

risingwavelabs/risingwave#18749

Related Doc PR

Resolve #54

Preview

https://risingwavelabs-wyx-resolve_54.mintlify.app/sql/commands/sql-create-source#shared-source

@WanYixian WanYixian marked this pull request as ready for review November 21, 2024 08:44
@WanYixian WanYixian requested a review from xxchan November 21, 2024 08:46
@WanYixian
Copy link
Collaborator Author

Please help take a look, and let me know if any comments, thanks! @xxchan

@xxchan xxchan requested review from stdrc, fuyufjh and st1page November 21, 2024 09:29
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@xxchan xxchan requested a review from tabVersion November 21, 2024 09:42
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sql/commands/sql-create-source.mdx Outdated Show resolved Hide resolved
sql/commands/sql-create-source.mdx Outdated Show resolved Hide resolved
WanYixian and others added 2 commits November 22, 2024 09:42
Co-authored-by: Eric Fu <[email protected]>
Signed-off-by: IrisWan <[email protected]>
Co-authored-by: Eric Fu <[email protected]>
Signed-off-by: IrisWan <[email protected]>
@WanYixian WanYixian merged commit 51a878a into main Nov 22, 2024
2 checks passed
@WanYixian WanYixian deleted the wyx/resolve_54 branch November 22, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document: feat: enable shared source in session variable by default, and add cluster-level config to disable
3 participants