Doc: upstream table name prefixed with database name #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikeW
reviewed
Nov 13, 2024
Updated, please take another look |
StrikeW
approved these changes
Nov 13, 2024
| @@ -87,7 +87,7 @@ CREATE TABLE [ IF NOT EXISTS ] table_name ( | |||
| WITH ( | |||
| snapshot='true' | |||
| ) | |||
| FROM source TABLE table_name; | |||
| FROM source TABLE database_name.table_name; | |||
There was a problem hiding this comment.
Suggest to use a identifier sqlserver_table_name in the syntax, and add explaination in the table below.
sqlserver_table_name: identifier of SQL Server table in the format of 'database_name.schema_name.table_name'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upstream table name needs to be prefixed with database name
Related code PR
risingwavelabs/risingwave#18868
Related doc issue
Resolve https://github.com/risingwavelabs/risingwave-docs/issues/2690
Preview