Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

risingwave 2.0.0 #44

Closed
wants to merge 5 commits into from
+17 −10
Closed

risingwave 2.0.0 #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5446b67
risingwave 2.0.0
BugenZhao Sep 18, 2024
88e6947
update connector resource
BugenZhao Sep 18, 2024
a0f4497
update contirbuting instructions
BugenZhao Sep 18, 2024
42ae2b5
address checklists
BugenZhao Sep 18, 2024
71d607a
set git_sha
BugenZhao Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions Formula/risingwave.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
class Risingwave < Formula

Check warning on line 1 in Formula/risingwave.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13-xlarge)

`brew linkage --cached --test --strict risingwavelabs/risingwave/risingwave` failed on macOS Ventura (13) on Apple Silicon! 

Indirect dependencies with linkage:
  [email protected]
desc "Distributed SQL database for stream processing"
homepage "https://github.com/risingwavelabs/risingwave"
url "https://github.com/risingwavelabs/risingwave/archive/refs/tags/v1.10.0.tar.gz"
sha256 "3ecb95e792bd16afa7404b74e3b624b798f4824cbad668fb38d536dabbb8f5e3"
url "https://github.com/risingwavelabs/risingwave/archive/refs/tags/v2.0.0.tar.gz"
sha256 "79d50be48c2a800443a713577827efa0146a4b8a1396dc1226d860b334c4dbed"
license "Apache-2.0"
head "https://github.com/risingwavelabs/risingwave.git", branch: "main"

Expand All @@ -20,11 +20,11 @@
depends_on "openssl@3"

resource "connector" do
url "https://github.com/risingwavelabs/risingwave/releases/download/v1.10.0/risingwave-v1.10.0-x86_64-unknown-linux-all-in-one.tar.gz"
sha256 "cf4927c62c2234567a2d87256fee217ae853300e12a2f7e9b28a0c873d823129"
url "https://github.com/risingwavelabs/risingwave/releases/download/v2.0.0/risingwave-v2.0.0-x86_64-unknown-linux-all-in-one.tar.gz"
sha256 "741e6a79a59b30ae8c8bba0473a25d66427472883e8374f1fd592603c2944fd6"
end

def install

Check failure on line 27 in Formula/risingwave.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-13-large)

`brew install --verbose --formula --build-bottle risingwavelabs/risingwave/risingwave` failed on macOS Ventura (13)! 

/usr/bin/env tar --extract --no-same-owner --file /Users/runner/Library/Caches/Homebrew/downloads/b43b2c31a90d9379711d168e22f79455f81d5505f4e00857a813157224d0f0b3--risingwave-2.0.0.tar.gz --directory /private/tmp/homebrew-unpack20240918-30770-iwopbr
/usr/bin/env cp -pR /private/tmp/homebrew-unpack20240918-30770-iwopbr/risingwave-2.0.0/. /private/tmp/risingwave-20240918-30770-tbsa3q/risingwave-2.0.0
==> /usr/local/opt/rustup/bin/rustup-init -qy --no-modify-path --default-toolchain none
warning: it looks like you have an existing installation of Rust at:
warning: /usr/local/opt/rustup/bin
warning: It is recommended that rustup be the primary Rust installation.
warning: Otherwise you may have confusion unless you are careful with your PATH
warning: If you are sure that you want both rustup and your already installed Rust
warning: then please reply `y' or `yes' or set RUSTUP_INIT_SKIP_PATH_CHECK to yes
warning: or pass `-y' to ignore all ignorable checks.
error: cannot install while Rust is installed
warning: continuing (because the -y flag is set and the error is ignorable)
error: $HOME differs from euid-obtained home directory: you may be using sudo
error: $HOME directory: /private/tmp/risingwave-20240918-30770-tbsa3q/risingwave-2.0.0/.brew_home
error: euid-obtained home directory: /Users/runner
info: profile set to 'default'
info: default host triple is x86_64-apple-darwin
info: skipping toolchain installation


Rust is installed now. Great!

To get started you need Cargo's bin directory 
(/Users/runner/Library/Caches/Homebrew/cargo_cache/bin) in your PATH
environment variable. This has not been done automatically.

To configure your current shell, you need to source
the corresponding env file under 
/Users/runner/Library/Caches/Homebrew/cargo_cache.

This is usually done by running one of the following (note the leading DOT):
. "/Users/runner/Library/Caches/Homebrew/cargo_cache/env"            # For 
sh/bash/zsh/ash/dash/pdksh
source "/Users/runner/Library/Caches/Homebrew/cargo_cache/env.fish"  # For fish
==> cargo install --profile production --bin risingwave --features rw-static-link --features all-udf --jobs 12 --locked --root=/usr/local/Cellar/risingwave/2.0.0/libexec --path=src/cmd_all
info: syncing channel updates for 'nightly-2024-06-06-x86_64-apple-darwin'
info: latest update on 2024-06-06, rust version 1.80.0-nightly (72fdf913c 2024-06-05)
info: downloading component 'cargo'
info: downloading component 'clippy'
info: downloading component 'rust-docs'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: downloading component 'rustfmt'
info: installing component 'cargo'
info: installing component 'clippy'
info: installing component 'rust-docs'
info: installing component 'rust-std'
info: installing component 'rustc'
info: installing component 'rustfmt'
  Installing risingwave_cmd_all v2.0.0 (/private/tmp/risingwave-20240918-30770-tbsa3q/risingwave-2.0.0/src/cmd_all)
    Updating git repository `https://github.com/risingwavelabs/bson-rust`
    Updating git repository `https://github.com/madsim-rs/futures-timer.git`
    Updating git repository `https://github.com/madsim-rs/getrandom.git`
    Updating git repository `https://github.com/madsim-rs/quanta.git`
    Updating git repository `https://github.com/kwannoel/sqlx.git`
    Updating git repository `https://github.com/madsim-rs/rust-postgres.git`
    Updating git repository `https://github.com/madsim-rs/rust-tokio-retry.git`
    Updating crates.io index
    Updating git repository `https://github.com/risingwavelabs/iceberg-rust.git`
    Updating git repository `https://github.com/madsim-rs/tokio.git`
    Updating git repository `https://github.com/risingwavelabs/jemallocator.git`
    Updating git submodule `https://github.com/jemalloc/jemalloc`
    Updating git repository `https://github.com/risingwavelabs/lru-rs.git`
    Updating git repository `https://github.com/risingwavelabs/darwin-libproc.git`
    Updating git repository `https://github.com/risingwavelabs/avro`
    Upd
# this will install the necessary cargo/rustup toolchain bits in HOMEBREW_CACHE
system "#{Formula["rustup"].bin}/rustup-init",
"-qy", "--no-modify-path",
Expand Down Expand Up @@ -55,10 +55,14 @@
# Enable building embedded dashboard.
ENV["ENABLE_BUILD_DASHBOARD"] = "1"

# Will show "x.y.z (Homebrew)" in the version string.
ENV["GIT_SHA"] = "Homebrew"

system "cargo", "install",
# "--profile", "production", # since the upcoming release 1.11 (or 2.0)
"--profile", "production",
"--bin", "risingwave",
"--features", "rw-static-link",
"--features", "all-udf",
*std_cargo_args(root: libexec, path: "src/cmd_all")

resource("connector").stage do
Expand Down
13 changes: 8 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,13 @@ $ $(brew --prefix [email protected])/bin/risingwave --version

## Contributing

Bump formula version:
```bash
# 1. Bump the version in the formula
brew bump-formula-pr risingwave --version x.y.z

```
brew bump-formula-pr risingwave --url https://github.com/risingwavelabs/risingwave/archive/refs/tags/v<x.y.z>.tar.gz
```
# 2. Switch to the newly created branch
git switch bump-risingwave-x.y.z

At the same time, copy the old formula to `risingwave@<x.y>` and change its class name to `RisingwaveAT<xy>`, so that the old version can still be installed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't maintain old version any more?

# 3. Manually update the `resource "connector"` section in `Formula/risingwave.rb`
code Formula/risingwave.rb
```
Loading