-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala 3 Draft PR #205
base: scala-3-prep
Are you sure you want to change the base?
Scala 3 Draft PR #205
Conversation
I see that you have changed some lazy vals to defs, could that be part of the performance regression? |
In elevate macros you are wrapping these everywhere (strategies, combinators): try ... catch
case _: MatchError => Failure(this) I don't think this is what we used to do? |
In src/main/scala/elevate/core/strategies/debug.scala, there are rule definitions which look more like strategies to me. I think we should be careful about what is a rule and what is a strategy? |
normalize.apply( | ||
normalize( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally :)
@@ -1,18 +1,20 @@ | |||
package apps | |||
|
|||
import apps.separableConvolution2D._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import apps.separableConvolution2D.*
, or delete?
@@ -6,6 +6,8 @@ import shine.OpenCL._ | |||
import shine.cuda.KernelExecutor.{KernelNoSizes, KernelWithSizes} | |||
import util._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the difference between import x._
and import x.*
?
This is a draft PR porting
shine
and all dependent repositories to Scala 3.At the moment of opening this PR, there exists a large performance regression that me need to address before merging.
Here are the changes made in: