Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cbuildcap and ctestsubset do not use DDC #82

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

francislaus
Copy link
Contributor

@francislaus francislaus commented Feb 1, 2024

This should close #18

I decided to not make cs1==0 RESERVED because it is a valid input.

@francislaus
Copy link
Contributor Author

I had a longer discussion with @PeterRugg and he explained that cbuildcap also clears the otype if it is successful. In the current form cbuildcap can be used for tag clearing, but this would change if the spec got more otypes later.

@francislaus
Copy link
Contributor Author

What was the reasoning for not having a ccleartag instruction? @tariqkurd-repo

@andresag01
Copy link
Collaborator

andresag01 commented Feb 2, 2024

@francislaus: The expectation was ccleartag is not a common instruction, so it was not included in the current proposal to save encoding space. It could be added if there is a strong use-case for it, or as a pseudo-instruction implemented using cbuildcap like @arichardson suggested.

@tariqkurd-repo, what do you think about ccleartag?

@francislaus
Copy link
Contributor Author

@tariqkurd-repo What were your thoughts about ccleartag?

Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this being merged as is and I've filed #94 for the CClearTag question.

@arichardson
Copy link
Collaborator

I'm happy with this being merged as is and I've filed #94 for the CClearTag question.

And by merge I mean squash+merge to avoid the fixup commits in the history.

@andresag01 andresag01 merged commit 854d3b5 into riscv:main Feb 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cbuildcap and ctestsubset and the use of DDC
4 participants