clarify PTE fault exception priority, and add into instruction pages #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timmmm
reviewed
Dec 13, 2024
Timmmm
reviewed
Dec 13, 2024
tariqkurd-repo
commented
Dec 16, 2024
Signed-off-by: Tariq Kurd <[email protected]>
Timmmm
approved these changes
Dec 16, 2024
tariqkurd-repo
commented
Dec 17, 2024
tariqkurd-repo
commented
Dec 17, 2024
Signed-off-by: Tariq Kurd <[email protected]>
jrtc27
reviewed
Dec 17, 2024
|
|
||
| If a store page fault is caused by a CHERI <<cheri_pte_ext,PTE>> fault, then set bit zero of <<mtval2>> to 1 and all other bits to 0, otherwise set all bits to zero. | ||
| NOTE: Reporting both allows the software the choice about which action to take first, for example a write to a |
There was a problem hiding this comment.
This confuses me. Load-side revocation will never do any sweeping on stores, so value 2 isn't useful, it will be treated the same as 1. As for loads, yes, sweeping occurs there, but there's nothing else really to do if both faults occur (for non-tag-dependent implementations) over and above just a CHERI PTE fault, and if your implementation is tag-dependent then the RISC-V page fault and CHERI PTE fault are strictly serial so it's impossible to have both at once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #484