Use stval/stval2 for HS-mode exceptions, not htval/htval2 #483
+0
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htval exists solely to communiate extra information to HS-mode about VS-mode faults to HS-mode, currently just the guest physical address for G-stage page faults. CHERI exceptions can and must (to align with other kinds of faults, including HS-mode's own faults) use stval/stval2 when trapping from HS-mode. Fixes riscv#482
|
The last sentence of the commit message should probably read "...when trapping to HS-mode". Otherwise LGTM. |
The text I deleted talked of exceptions "taken in HS-mode", which to me means "from HS-mode". But I agree that, on rereading, it probably meant to say "to HS-mode", because otherwise M-mode could be handling them and then using htval(2) makes even less sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
htval exists solely to communiate extra information to HS-mode about VS-mode faults to HS-mode, currently just the guest physical address for G-stage page faults. CHERI exceptions can and must (to align with other kinds of faults, including HS-mode's own faults) use stval/stval2 when trapping from HS-mode.
Fixes #482