Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid address csr updates #456

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Conversation

tariqkurd-repo
Copy link
Collaborator

@tariqkurd-repo tariqkurd-repo commented Nov 28, 2024

fix #455

@tariqkurd-repo tariqkurd-repo changed the title fix https://github.com/riscv/riscv-cheri/issues/455 invalid address csr updates Nov 28, 2024
@tariqkurd-repo
Copy link
Collaborator Author

@jamie-melling

src/riscv-integration.adoc Outdated Show resolved Hide resolved
Copy link
Collaborator

@nwf nwf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads a little rough to me. I've tried proposing some other prose, but won't claim it to be perfect.

src/riscv-integration.adoc Outdated Show resolved Hide resolved
src/riscv-integration.adoc Outdated Show resolved Hide resolved
tariqkurd-repo and others added 3 commits December 6, 2024 11:30
Co-authored-by: Nathaniel Wesley Filardo <[email protected]>
Signed-off-by: Tariq Kurd <[email protected]>
Co-authored-by: Nathaniel Wesley Filardo <[email protected]>
Signed-off-by: Tariq Kurd <[email protected]>
@tariqkurd-repo
Copy link
Collaborator Author

I updated the wording the steal the invalid address description text form the risc-v priv manual

@tariqkurd-repo tariqkurd-repo merged commit 7cc80fd into main Dec 6, 2024
2 checks passed
@tariqkurd-repo tariqkurd-repo deleted the illegal_address_handling branch December 6, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should CSR invalid address handling also apply to HW updates of CSRs?
3 participants