Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mavis is now a library; reduces build time and .o sizes #95

Merged
1 commit merged into from
Oct 13, 2023
Merged

Mavis is now a library; reduces build time and .o sizes #95

1 commit merged into from
Oct 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 5, 2023

No description provided.

@ghost ghost added the enhancement New feature or request label Oct 5, 2023
@ghost ghost self-assigned this Oct 5, 2023
peter-d
peter-d reviewed Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@peter-d peter-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one minor remark.

As a side note: I've switched jobs and as a result am running on different hardware now - I am no longer able to check MacOS/Apple M1 clang on my side.

CMakeLists.txt Show resolved Hide resolved
@ghost ghost merged commit c23b533 into master Oct 13, 2023
2 checks passed
@ghost ghost deleted the knutel/updated_mavis branch October 13, 2023 13:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathlenemagnus kathlenemagnus Awaiting requested review from kathlenemagnus

@aarongchan aarongchan Awaiting requested review from aarongchan

@arupc-vmicro arupc-vmicro Awaiting requested review from arupc-vmicro

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter-d @arupc