Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector tester clean up #241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kathlenemagnus
Copy link
Collaborator

Added a parameter to the Vector tester to be able to reduce code size. Also removed several redundant tests.

@jeffnye-gh
Copy link
Collaborator

I'm trying to determine if I have a problem in my environment.

I tried building this branch I get this:

/home/jeff/miniconda3/envs/sparta/include/sparta/utils/SpartaSharedPointer.hpp:376:31: error: pointer may be used after 'void operator delete(void*, std::size_t)' [-Werror=use-after-free]
376 | --ref_count_->count;
| ~~~~~~~~~~~~^~~~~
And this
/home/jeff/miniconda3/envs/sparta/include/sparta/utils/SpartaSharedPointer.hpp:365:21: note: call to 'void operator delete(void*, std::size_t)' here
365 | delete ref_count;
| ^~~~~~~~~~~~~~~~

I'm using this version of sparta
commit f1d0a5cdeb5ff718360a162d9ab7b13f19e70c3e (HEAD -> map_v2, tag: map_v2.0.19, origin/map_v2)
Merge: fdcc9275 05ba8532
Author: Knute Lingaard [email protected]
Date: Thu Nov 14 13:34:19 2024 -0600

Merge remote-tracking branch 'origin/master' into map_v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants