unit test template #236
Merged
unit test template #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 3, 2024 14:54
rmv unnecessary comment in top cmake lists typos in readme and check_files
|
this fails for MAC OS but I do not see a connection between my PR and the mac failure. I believe it fails due to the warning installing conda. Warning: Future Miniforge releases will NOT build Mambaforge installers. We advise you switch to Miniforge at your earliest convenience. More details at https://conda-forge.org/news/2024/07/29/sunsetting-mambaforge/. |
|
re-running the checks with-out change, it now works. |
klingaard
approved these changes
Dec 16, 2024
|
Hi Knute.
Yes, moving it to sparta is fine with me. Couple questions.
Does this collide with SkeletonPipeline? Honestly I'm only now noticing
that sparta example and the similarities, my bad.
If moved into sparta should it be only there, or in both olympia and sparta
?
Your call.
Jeff
…On Mon, Dec 16, 2024 at 11:18 AM Knute ***@***.***> wrote:
***@***.**** approved this pull request.
This is super awesome. What are your thoughts about moving this into
Sparta?
—
Reply to this email directly, view it on GitHub
<#236 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A25MMC62VWSVG4PLNPTBPMD2F4DMXAVCNFSM6AAAAABTCVXQYGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBWHAYTQOBZG4>
.
You are receiving this because you were assigned.Message ID:
***@***.***
com>
|
|
I don't think it collides with anything in Sparta, really. If we do put this in sparta, a set of cool scripts would be nice to set up a unit. But I think here is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A unit test bench template. It intends to help new users create unit tests.
Three components, Src, Sink, Dut. Handles json and stf input test types.
Conforms to coding style through clang-formt.
I created this for myself a while back to help learning the concepts, updated for coding style.
It was useful to me when learning sparta/map/olympia.