Raise exception in LSU when ROB is drained #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingaard
reviewed
Oct 31, 2023
h0lyalg0rithm
force-pushed
the
lsu_drained
branch
from
bc71fc3 to
44d9a9e
Compare
h0lyalg0rithm
force-pushed
the
lsu_drained
branch
from
44d9a9e to
a385d57
Compare
My bad just fixed it |
ghost
reviewed
Nov 2, 2023
ghost
reviewed
Nov 2, 2023
ghost
reviewed
Nov 2, 2023
Co-authored-by: Knute Lingaard <[email protected]> Signed-off-by: Suraj Shirvankar <[email protected]>
Co-authored-by: Knute Lingaard <[email protected]> Signed-off-by: Suraj Shirvankar <[email protected]>
danbone
reviewed
Nov 8, 2023
ghost
reviewed
Nov 8, 2023
h0lyalg0rithm
commented
Nov 9, 2023
h0lyalg0rithm
force-pushed
the
lsu_drained
branch
from
733a886 to
a738bbb
Compare
h0lyalg0rithm
commented
Nov 13, 2023
|
I pushed changes to this PR to origin/lsu_drained. Please pull those changes into your fork. |
ghost
assigned
Thanks Knute |
ghost
reviewed
Nov 13, 2023
|
At your earliest convenience, @h0lyalg0rithm can you update this branch (resolve conflicts)? |
|
@klingaard I synced it up with master |
klingaard
approved these changes
Dec 21, 2023
LiGaOg
pushed a commit
to LiGaOg/riscv-perf-model
that referenced
this pull request
Jan 8, 2024
This PR adds a notification from ROB to the entire simulation that the ROB is about to or is expecting simulation to correctly terminate. If a unit listens for that notification, it can use that information to determine if simulation ended improperly, meaning, it might still have work to do, but didn't expect simulation to stop. An example of how this can happen: a unit is NOT scheduling an event to do work (a bug) because of a missed path to "wake" it up. If the sparta::Scheduler ends simulation because it has no events to run, the unit will not receive the end-of-simulation notification from the ROB and can throw an exception in this case. --------- Signed-off-by: Suraj Shirvankar <[email protected]> Co-authored-by: Knute Lingaard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #90