Refer to the RISC-V C API document for preprocessor definitions #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list in this document is incomplete, and the riscv-c-api-doc repo has since been created to hold this kind of information. Let's just point there rather than trying to maintain the same information in two places. That document doesn't mention that older version of GCC defined `__riscv__` but I think this is just a historical curiousity at this point, so this isn't a real loss of information.
cmuellner
reviewed
Sep 10, 2024
cmuellner
approved these changes
Sep 10, 2024
Merged
We could, but it's probably helpful for readers who might have been used to checking in this doc to have a pointer to the right location. Perhaps when a new intro is added that links to relevant documents and better explains the scope of this document might be a good time for doing such a removal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list in this document is incomplete, and the riscv-c-api-doc repo has since been created to hold this kind of information. Let's just point there rather than trying to maintain the same information in two places.
That document doesn't mention that older version of GCC defined
__riscv__but I think this is just a historical curiousity at this point, so this isn't a real loss of information.