Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert unsigned long to uint*_t #115

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Convert unsigned long to uint*_t #115

merged 2 commits into from
Jan 2, 2025

Conversation

steven-bellock
Copy link
Contributor

Fix #91.

@steven-bellock steven-bellock marked this pull request as ready for review December 18, 2024 15:48
@steven-bellock steven-bellock changed the title Convert unsigned long to uint32_t Convert unsigned long to uint32_t Dec 18, 2024
@rsahita
Copy link
Collaborator

rsahita commented Dec 19, 2024

@atishp04 fyi

@atishp04
Copy link
Contributor

atishp04 commented Dec 19, 2024 •
edited
Loading

tsm_capabilities is a bitmask. Thus, unsigned long allow more bits for the future for more common use case for virtualization (RV64). Currently, the bitmask table is defined accordingly as well.
I don't think it matters much for tvm_max_vcpus as it is highly unlikely that you would need vcpus > UINT32_MAX anyways.

@steven-bellock
Copy link
Contributor Author

unsigned long allow more bits

We can make it uint64_t. I assume the number of capabilities will be the same for both RV32 and RV64.

rsahita
rsahita reviewed Jan 2, 2025
View reviewed changes
src/sbi_cove.adoc Outdated Show resolved Hide resolved
rsahita
rsahita reviewed Jan 2, 2025
View reviewed changes
src/sbi_cove.adoc Outdated Show resolved Hide resolved
@rsahita
Apply suggestions from PR review
7d10069 
using uint64_t for fixed sized (non-arch) params

Signed-off-by: Ravi Sahita <[email protected]>
@rsahita rsahita merged commit c2c058e into riscv-non-isa:main Jan 2, 2025
2 checks passed
@steven-bellock steven-bellock deleted the fix-91 branch January 2, 2025 19:55
@steven-bellock steven-bellock changed the title Convert unsigned long to uint32_t Convert unsigned long to uint*_t Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsahita rsahita rsahita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert unsigned long to uint*_t
3 participants
@steven-bellock @rsahita @atishp04