-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-4329: Ketch footer and Segment updates #179
Open
eric-schneider
wants to merge
21
commits into
main
Choose a base branch
from
DOC-4329-footer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
9fee0e0
Add consent management link to footer
eric-schneider 35bacac
dynamic footer text and consent context added to segment calls
colegoldsmith c0dd2bc
fix consent object
colegoldsmith e00c57d
Make footer link conditional
eric-schneider bbca953
Shorten data-track attribute
eric-schneider 55e9c9f
Squash merge remove-gtm-scripts into DOC-4329-footer
colegoldsmith b5697a9
fix track events so they use consent context correctly. Only load seg…
colegoldsmith a2de33e
Merge branch 'main' into DOC-4329-footer
colegoldsmith 0cf2a0f
manual ketch url for testing purposes, revert this soon
colegoldsmith 6a7cfaf
test showing ketch preferences on load
colegoldsmith 23e91e0
fix segment object
colegoldsmith ecabb4f
load segment initially, update ketch scripts
colegoldsmith 9213d6a
hard code keys
colegoldsmith a363a1c
undo hard coded site keys
colegoldsmith 3c2eea0
add ketch logic to js file and let middleware handle context
colegoldsmith ec60950
update to latest changes from marketing without gtag scripts
colegoldsmith 89d00a4
UNDO THIS - hard coding segment and ketch site keys
colegoldsmith 0350d78
use segment prod source
colegoldsmith 459745d
force a rebuild
colegoldsmith 0663bb2
use dev segment source
colegoldsmith 2652537
add gtag script and use staging www site footer link
colegoldsmith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed in the segment docs this
consent
object uses boolean values instead of strings. I think This values should be based on the ketch preferencesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @EladioGaldamez! I copied some of your PR and created a global scope track event that includes the correct consent context gathered from what the user selects in the Ketch popup