Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use json gem instead of oj #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use json gem instead of oj #75

wants to merge 2 commits into from

Conversation

jordan-brough
Copy link
Member

I was reading this blog post: https://byroot.github.io/ruby/json/2024/12/15/optimizing-ruby-json-part-1.html where the new maintainer of the json gem says:

I was recently made maintainer of the json gem, and aside from fixing some old bugs, I focused quite a bit on its
performance, so that it is now the fastest JSON parser and generator for Ruby on most benchmarks.

Since JSON is the default Ruby gem and is also now the fastest (by his claim, at least), it seems like it'd be nice to go with that and avoid an extra dependency, unless we have another reason to use Oj.

NOTE: Tests on master seem to be failing. See this test PR: #74

jordan-brough and others added 2 commits December 19, 2024 17:29
I was reading this blog post: https://byroot.github.io/ruby/json/2024/12/15/optimizing-ruby-json-part-1.html
where the new maintainer of the json gem says:

> I was recently made maintainer of the json gem, and aside from fixing some old bugs, I focused quite a bit on its
> performance, so that it is now the fastest JSON parser and generator for Ruby on most benchmarks.

Since JSON is the default Ruby gem and is also now the fastest (by his claim, at least), it seems like it'd be nice to
go with that and avoid an extra dependency, unless we have another reason to use Oj.
@jordan-brough
Copy link
Member Author

@alexstoick thanks for fixing the specs!

Does this look OK to merge @alexstoick @reidnimz? (After the holidays)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants